fix(column): ♻️ remove ErrorWhisker and Tooltip when error is null #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptbrowne
approved these changes
Nov 6, 2023
lloydrichards
changed the title
|
Nice! There is only one caveat: we can also have standard error whiskers for grouped column charts, I think the logic needs to be applied there too 😁 Nit: you can also add a relevant bullet point to the CHANGELOG, so at the end we have a nice list of all the changes made to the app ✨ |
lloydrichards
force-pushed
the
refactor/remove-standard-error
branch
from
4f7d4c2 to
acc1300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was requested to remove the Standard Errors from the column visualization (#589) so that the ErrorWhiskers component does not show for these columns.
While I was able to filter the chartDatum for any values where the getYError was null, I was also able to remove the getError from the getAnnotationinfo when null
Before
After