Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dates with timezones are now correctly parsed #1237

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix: Dates with timezones are now correctly parsed #1237

merged 1 commit into from
Oct 31, 2023

Conversation

bprusinowski
Copy link
Collaborator

Fixes #1233.

@vercel
Copy link

vercel bot commented Oct 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 11:31am

@bprusinowski bprusinowski linked an issue Oct 27, 2023 that may be closed by this pull request
An xsd:dateTime dimension displays "-" when values have a timezone as "+01:00" #1233
Closed
Base automatically changed from perf/optimize-rdf-queries to main October 31, 2023 13:44
@bprusinowski bprusinowski merged commit 79858fb into main Oct 31, 2023
2 of 3 checks passed
@bprusinowski bprusinowski deleted the fix/parse-dates-with-timezones branch October 31, 2023 13:57
@Rdataflow
Copy link
Contributor

Rdataflow commented Oct 31, 2023 •
edited by bprusinowski
Loading

@bprusinowski well done

  • one minor observation I'd like you to fix:
    • in edit mode table view clicking on the dimension Active since I get the metadata w/ timezone whereas in the table I get the timestamps in local time. 
      Available values
Min: 2022-08-18T14:08:43+02:00
Max: 2023-09-25T11:19:08+02:00

@bprusinowski bprusinowski mentioned this pull request Nov 1, 2023
Merged
@bprusinowski
Copy link
Collaborator Author

@Rdataflow see #1242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptbrowne ptbrowne Awaiting requested review from ptbrowne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An xsd:dateTime dimension displays "-" when values have a timezone as "+01:00"
2 participants
@bprusinowski @Rdataflow