perf: Disable loading of dimension values for preview query #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…into perf/disable-loading-dimension-values-for-preview
…into perf/disable-loading-dimension-values-for-preview
bprusinowski
deleted the
perf/disable-loading-dimension-values-for-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1192.
To improve performance of fetching the dataset preview, this PR disables loading of dimension values along with it.
It means that we lose the feature to sort the preview by value positions, but for 10-observations preview that might not be necessary anyway.
At first I tried to add a new GQL fragment,
DimensionMetadataWithoutValuesFragment, but ultimately I decided to introduce a new property todataCubeByIriquery –disableValuesLoad– to keep the same types, as we useDimensionMetadataFragmentacross the whole application, and the preview query is scoped to one components (dataset preview table).