Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to create and publish multiple charts at once #1159

Merged
merged 44 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
944a40b
chore: Clean up
bprusinowski Aug 31, 2023
eddc3dc
refactor: Add GenericChartConfig type
bprusinowski Aug 31, 2023
f391595
feat: Initial implementation of multiple charts at once
bprusinowski Sep 5, 2023
824587b
fix: Keep chart key when getting adjusted chart config
bprusinowski Sep 5, 2023
4eb01d7
chore: Remove console.logs
bprusinowski Sep 5, 2023
565cf0a
feat: Highlight active chart in tabs
bprusinowski Sep 5, 2023
fd9698d
fix: Use chart meta when displaying title and subtitle
bprusinowski Sep 5, 2023
9f45fe1
fix: Tests
bprusinowski Sep 5, 2023
e083815
refactor: Use simpler method to replace chart config
bprusinowski Sep 5, 2023
ba50513
fix: Change correct chart (selection tabs)
bprusinowski Sep 5, 2023
bb6f246
fix: Derive filters when switching chart type
bprusinowski Sep 5, 2023
3f68bba
refactor: Improve logic to get active chart config
bprusinowski Sep 5, 2023
b6aa272
refactor: Pass chart config to color legend
bprusinowski Sep 5, 2023
0e86f27
refactor: Clean up ChartPanel and SelectionTabs
bprusinowski Sep 6, 2023
e7a5081
refactor: Active chart key is always defined from certain point
bprusinowski Sep 6, 2023
c83dc2d
feat: Store configurator state version in the db
bprusinowski Sep 6, 2023
31a6dc3
refactor: Remove unused props
bprusinowski Sep 6, 2023
fbc7f78
feat: Do not show ChartSelectionTabs for single chart in published mode
bprusinowski Sep 6, 2023
f89efb8
fix: Initialize a new chart in editing mode with CONFIGURING_CHART state
bprusinowski Sep 6, 2023
1c01783
fix: Store chartConfigs as array, not object
bprusinowski Sep 6, 2023
cd4b5b0
feat: Store activeChartKey in db
bprusinowski Sep 6, 2023
41ed59c
feat: Add PUBLISHED configurator state
bprusinowski Sep 6, 2023
ed41906
refactor: Use configurator state in published charts
bprusinowski Sep 6, 2023
6ff1aaa
refactor: Derive editable prop dynamically
bprusinowski Sep 6, 2023
9380e6d
style: Improve design of SelectionTabs
bprusinowski Sep 6, 2023
4fd1bec
feat: Add a way to add a given chart type
bprusinowski Sep 7, 2023
080925e
feat: Add a way to remove charts
bprusinowski Sep 7, 2023
ebb882e
style: Set tab width
bprusinowski Sep 7, 2023
6dcb379
feat: Add a way to duplicate charts
bprusinowski Sep 7, 2023
e7c1979
Merge branch 'main' of github.com:visualize-admin/visualization-tool …
bprusinowski Sep 7, 2023
8165d65
feat: Reverse remove and duplicate this visualization buttons
bprusinowski Sep 7, 2023
5663775
feat: Hide dashboards behind a flag
bprusinowski Sep 7, 2023
71430dd
fix: Reset chart container height on chart switch
bprusinowski Sep 8, 2023
96a59f1
refactor: Use type guard
bprusinowski Sep 8, 2023
eb1e315
docs: Add comment
bprusinowski Sep 11, 2023
f8298f2
refactor: Clean up
bprusinowski Sep 12, 2023
68a5996
feat: Make chart selection tabs draggable
bprusinowski Sep 15, 2023
7fc6d4e
feat: Only make it possible to drag chart tab when it makes sense
bprusinowski Sep 15, 2023
8caacc7
feat: Add initial scroll behavior to chart tabs
bprusinowski Sep 15, 2023
f747245
refactor: Smaller improvements
bprusinowski Sep 15, 2023
1b99589
Merge branch 'main' of github.com:visualize-admin/visualization-tool …
bprusinowski Sep 27, 2023
0348426
Merge branch 'main' of github.com:visualize-admin/visualization-tool …
bprusinowski Oct 6, 2023
41b0d55
Merge branch 'main' of github.com:visualize-admin/visualization-tool …
bprusinowski Oct 10, 2023
5afbba3
chore: Remove dashboards flag
bprusinowski Oct 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/configurator/configurator-state.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1455,6 +1455,7 @@ const ConfiguratorStateProviderInternal = ({
};
}),
],
activeChartKey: state.chartConfigs[0].key,
bprusinowski marked this conversation as resolved.
Show resolved Hide resolved
});

/**
Expand Down
1 change: 1 addition & 0 deletions app/utils/chart-config/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export const createConfig = async (state: ConfiguratorStatePublishing) => {
dataSource: state.dataSource,
meta: state.meta,
bprusinowski marked this conversation as resolved.
Show resolved Hide resolved
chartConfigs: state.chartConfigs,
activeChartKey: state.activeChartKey,
},
},
});
Expand Down