fix: Allow multiple identical labels in charts #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Would provide a way to differentiate observations client side otherwise we only have the label and it is not sufficient
...to be able to retrieve observations based on IRI and not solely on label
bprusinowski
force-pushed
the
fix/same-labelled
branch
from
075a3bb to
fa3317e
Compare
bprusinowski
changed the title
bprusinowski
force-pushed
the
fix/same-labelled
branch
from
fa3317e to
0eddd9d
Compare
bprusinowski
force-pushed
the
fix/same-labelled
branch
from
52edd10 to
a0ab0c1
Compare
...there are two rendering modes for base maps, overlaid or interleaved (see https://deck.gl/docs/get-started/using-with-map). Previously we used interleaved mode, which caused the problems with hovering over overlapping shapes (wrong element was highlighted). Setting the option to recommended, overlaid mode, fixes the tooltip issues (and seems to have no impact on overall performance / behavior of the map).
...which led to undefined dataset when fetching hierarchies in ColorLegend and thus wrong (missing) hierarchical division
ptbrowne
commented
Apr 13, 2023
ptbrowne
commented
Apr 13, 2023
- Interleaved should be there for data layer polygons to be under lakes / roads - depthTest: false makes picking not buggy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bprusinowski is the author of the PR.
Fixes #1015.
This PR changes the way we index observations from indexing by label (or abbreviation) to indexing by value (for hierarchical dimensions, passed in a form of an additional property:
dimensionIri/__iri__) or label (or abbreviation).Basically, we change
{ label_or_abbreviation: Observation }into{ value_or_label_or_abbreviation: Observation }.We needed to make this change to allow displaying values with the same labels, which is now a case with hierarchical dimensions (but in most places, we are able to distinguish them anyway, either by a color legend below a chart or visually on the map).
There are also smaller bug fixes / improvements included:
CircleLegendlabelsdataSetprop toPublishedConfiguratorStateto fix loading hierarchies forColorLegendHow to test