Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design alignments #620

Closed
4 tasks done
ptbrowne opened this issue Aug 16, 2022 · 8 comments · Fixed by #632 or #644
Closed
4 tasks done

Design alignments #620

ptbrowne opened this issue Aug 16, 2022 · 8 comments · Fixed by #632 or #644
Assignees
Labels
enhancement New feature or request

Comments

@ptbrowne
Copy link
Collaborator

ptbrowne commented Aug 16, 2022

@AnninaWalker has made coherence improvements to the design that we should implement.

  • Adjusting and aligning the font sizes : changed all the font sizes within
    • the dropdowns
    • side bar elements (see screenshot) to 14 px instead of 16 px.
    • aligning current chart options components to match design specs (e.g. appearance of the checkbox, margin between form elements and their labels, etc), also see: Allow blocking of map controls #616 (comment)

image

@AnninaWalker
Copy link
Contributor

@ptbrowne If I go into the specs the sidebar elements are still 16px instead of 14px. It should be H5 instead of H4.

Image

@ptbrowne ptbrowne reopened this Aug 22, 2022
@ptbrowne
Copy link
Collaborator Author

ptbrowne commented Aug 22, 2022 via email

@AnninaWalker
Copy link
Contributor

@ptbrowne the font in the dropdowns should be changed to 14 px as well

@ptbrowne
Copy link
Collaborator Author

Fixed

@AnninaWalker
Copy link
Contributor

@ptbrowne Can you also apply the text size to the text within the dropdown menu?

Image

@ptbrowne
Copy link
Collaborator Author

Done.

@ptbrowne
Copy link
Collaborator Author

ptbrowne commented Oct 11, 2022 via email

@AnninaWalker
Copy link
Contributor

Yes for mobile

@ptbrowne ptbrowne added enhancement New feature or request and removed feature request labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants