Merge pull request #1592 from visualize-admin/feat/no-label

feat: Allow a tab not to have a label
visualize-admin · Jun 11, 2024 · e9bf51f · e9bf51f
2 parents 3c7315d + 1a6fb84
commit e9bf51f
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/app/components/chart-selection-tabs.tsx b/app/components/chart-selection-tabs.tsx
@@ -123,7 +123,7 @@ export const ChartSelectionTabs = () => {
           ? d.meta.title[locale]
           : d.meta.title[defaultLocale] !== ""
             ? d.meta.title[defaultLocale]
-            : t({ id: "annotation.add.title" }),
+            : undefined,
     };
   });
 
@@ -356,7 +356,7 @@ type TabDatum = {
   key: string;
   chartType: ChartType;
   active: boolean;
-  label: string;
+  label?: string | undefined;
 };
 
 type TabsFixedProps = {
@@ -757,7 +757,7 @@ const TabsInner = (props: TabsInnerProps) => {
                             sx={{
                               px: 0,
                               flexShrink: 1,
-                              minWidth: 180,
+                              minWidth: d.label ? 180 : 0,
                               flexBasis: "100%",
                             }}
                             label={
@@ -936,14 +936,16 @@ const TabContent = (props: TabContentProps) => {
       </Button>
 
       {label ? (
-        <Button
-          variant="text"
-          color="primary"
-          className={classes.label}
-          onClick={onSwitchClick}
-        >
-          {label}
-        </Button>
+        <Tooltip title={label} enterDelay={750}>
+          <Button
+            variant="text"
+            color="primary"
+            className={classes.label}
+            onClick={onSwitchClick}
+          >
+            {label}
+          </Button>
+        </Tooltip>
       ) : null}
       {editable && (
         <Button