Merge pull request #1171 from visualize-admin/fix/disappearing-colors

fix: Initialize color mapping with all values
visualize-admin · Sep 12, 2023 · e0a5198 · e0a5198 · vercel · Sep 12, 2023
2 parents 0fcf5b0 + 0c6dbbd
commit e0a5198
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ You can also check the [release page](https://github.com/visualize-admin/visuali
 
 ## Unreleased
 
+- Fixes
+  - It's now again possible to map all colors for hierarchical dimensions used as segmentation
 - Misc
   - Improved `langString` error message
 

diff --git a/app/charts/chart-config-ui-options.ts b/app/charts/chart-config-ui-options.ts
@@ -448,7 +448,7 @@ const defaultSegmentOnChange: OnEncodingChange<
   );
   const colorMapping = mapValueIrisToColor({
     palette,
-    dimensionValues: selectedValues,
+    dimensionValues: component ? component.values : selectedValues,
   });
   const multiFilter = makeMultiFilter(selectedValues.map((d) => d.value));
-Original file line number
+Diff line change
@@ Expand Up @@
     ## Unreleased
+    - Fixes
+      - It's now again possible to map all colors for hierarchical dimensions used as segmentation
     - Misc
       - Improved `langString` error message
@@ Expand Down @@