Merge pull request #1033 from visualize-admin/fix/copying-map-chart

fix: Undefined Map handlers during unmount
visualize-admin · May 15, 2023 · d036dc6 · d036dc6 · vercel · May 15, 2023
2 parents 6a2d4f2 + d490d27
commit d036dc6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/app/charts/map/map.tsx b/app/charts/map/map.tsx
@@ -364,6 +364,10 @@ export const MapComponent = () => {
           onIdle={() => {
             setLoaded(true);
           }}
+          onRemove={() => {
+            setLoaded(false);
+            setMap(null);
+          }}
           onLoad={(e) => {
             setMap(e.target);
             currentBBox.current = e.target.getBounds().toArray() as BBox;

diff --git a/app/charts/map/ref.ts b/app/charts/map/ref.ts
@@ -10,7 +10,7 @@ const getMap = () => {
   return map;
 };
 
-const setMap = (d: Map) => {
+const setMap = (d: Map | null) => {
   map = d;
 };