chore: Review comments

README.md

@@ -164,7 +164,7 @@ same storage, otherwise you'll have to reconfigure Keycloak.
 
 To configure Keycloak:
 
-- Access the [Keycloak admin][keycloak-admin]
+- Access the [Keycloak admin][keycloak-admin] (login, password: "admin", "admin")
 - Create client application
   - Via import: [Keycloak][keycloak-admin] > Clients > Import client
     - Use the exported client `keycloak-visualize-client-dev.json`

app/db/config.ts

@@ -11,6 +11,8 @@ import { createChartId } from "../utils/create-chart-id";
 
 import prisma from "./client";
 
+type PublishedConfig = Omit<ConfigType, "activeField">;
+
 /**
  * Store data in the DB.
  * If the user is logged, the chart is linked to the user.
@@ -49,9 +51,9 @@ const parseDbConfig = (conf: Config) => {
   const data = conf.data as ChartJsonConfig;
   const migratedData = {
     ...data,
-    dataSet: migrateDataSet(data.dataSet as string),
+    dataSet: migrateDataSet(data.dataSet),
     chartConfig: migrateChartConfig(data.chartConfig),
-  } as unknown as Omit<ConfigType, "activeField">;
+  } as PublishedConfig;
   return {
     ...conf,
     data: migratedData,

app/db/serialize.ts

@@ -6,8 +6,7 @@ export type Serialized<P> = P & {
 };
 
 export const serializeProps = <T extends unknown>(props: T) => {
-  const { json, meta } = SuperJSON.serialize(props);
-  const sprops = json;
+  const { json: sprops, meta } = SuperJSON.serialize(props);
   if (meta) {
     // @ts-ignore
     sprops._superjson = meta;

app/pages/api/auth/[...nextauth].ts

@@ -21,7 +21,7 @@ export const nextAuthOptions = {
   providers,
   callbacks: {
     /**
-     * When the is logged in, ensures it creates on our side and save its id
+     * When the user is logged in, ensures it creates on our side and save its id
      * on the session.
      */
     session: async ({ session, token }) => {