perf: useCallback

visualize-admin · Nov 2, 2023 · c8b119b · c8b119b
1 parent ecba93e
commit c8b119b
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/app/charts/combo/chart-combo-line-single.tsx b/app/charts/combo/chart-combo-line-single.tsx
@@ -83,6 +83,13 @@ export const ChartComboLineSingle = React.memo(
     const { chartConfig, measures } = props;
     const { interactiveFiltersConfig } = chartConfig;
 
+    const getLegendItemDimension = React.useCallback(
+      (label) => {
+        return measures.find((measure) => measure.label === label);
+      },
+      [measures]
+    );
+
     return (
       <ComboLineSingleChart aspectRatio={0.4} {...props}>
         <ChartContainer>
@@ -100,9 +107,7 @@ export const ChartComboLineSingle = React.memo(
           <LegendColor
             chartConfig={chartConfig}
             symbol="line"
-            getLegendItemDimension={(label) => {
-              return measures.find((measure) => measure.label === label);
-            }}
+            getLegendItemDimension={getLegendItemDimension}
           />
         </ChartControlsContainer>
       </ComboLineSingleChart>