Merge pull request #1728 from visualize-admin/feat/improve-styling

Feat/improve styling
visualize-admin · Sep 9, 2024 · 88ce659 · 88ce659
2 parents 1298d50 + d47091e
commit 88ce659
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -4,6 +4,9 @@
     "source.fixAll.eslint": "explicit",
     "source.organizeImports": "explicit"
   },
+  "editor.formatOnSave": true,
+  "editor.defaultFormatter": "esbenp.prettier-vscode",
+  "prettier.requireConfig": true,
   "eslint.validate": [
     "javascript",
     "javascriptreact",

diff --git a/app/components/copy-to-clipboard-text-input.tsx b/app/components/copy-to-clipboard-text-input.tsx
@@ -50,7 +50,7 @@ const useCopyToClipboardTextInputStyles = makeStyles((theme: Theme) => ({
     padding: `${theme.spacing(0)} ${theme.spacing(2)}`,
     flexGrow: 1,
     fontSize: "1rem",
-    minWidth: 160,
+    minWidth: 250,
     overflowX: "auto",
     borderTopLeftRadius: "default",
     borderBottomLeftRadius: "default",

diff --git a/app/components/publish-actions.tsx b/app/components/publish-actions.tsx
@@ -3,7 +3,6 @@ import {
   Box,
   Button,
   Divider,
-  Link,
   Popover,
   PopoverProps,
   Stack,
@@ -158,7 +157,7 @@ const Share = ({ configKey, locale }: PublishActionProps) => {
         );
       }}
     >
-      <Box m={4}>
+      <Box m={4} sx={{ "& > * + *": { mt: 4 } }}>
         <Flex
           sx={{
             justifyContent: "space-between",
@@ -217,19 +216,7 @@ const Share = ({ configKey, locale }: PublishActionProps) => {
           <Typography component="div" variant="body1" color="grey.700">
             <Trans id="publication.share.chart.url">Chart URL: </Trans>
           </Typography>
-          <Box my={1} sx={{ color: "primary" }}>
-            <Link
-              href={shareUrl}
-              sx={{
-                color: "primary",
-                textDecoration: "underline",
-                cursor: "pointer",
-                mr: 4,
-              }}
-            >
-              {shareUrl}
-            </Link>
-          </Box>
+          <CopyToClipboardTextInput content={shareUrl} />
         </Box>
       </Box>
     </TriggeredPopover>