Merge pull request #1655 from visualize-admin/fix/editing-aspect-ratio

fix: Editing aspect ratio
visualize-admin · Jul 8, 2024 · 7c39722 · 7c39722
2 parents 2b39c12 + d9ecb0c
commit 7c39722
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,7 +11,8 @@ You can also check the
 
 # Unreleased
 
-Nothing yet.
+- Fixes
+  - Going back to edit mode from free canvas layout no longer hides the chart
 
 # [4.7.1] - 2024-07-08
 

diff --git a/app/charts/shared/containers.tsx b/app/charts/shared/containers.tsx
@@ -10,6 +10,7 @@ import { useObserverRef } from "@/charts/shared/use-size";
 import {
   ChartConfig,
   hasChartConfigs,
+  isConfiguring,
   useConfiguratorState,
 } from "@/configurator";
 import { useTransitionStore } from "@/stores/transition";
@@ -67,7 +68,9 @@ export const ChartContainer = ({
       className={clsx(
         classes.chartContainer,
         classes[type],
-        state.layout.type === "dashboard" && state.layout.layout === "canvas"
+        !isConfiguring(state) &&
+          state.layout.type === "dashboard" &&
+          state.layout.layout === "canvas"
           ? null
           : classes.constrainMinHeight
       )}