feat: Remove shared dashboard filters flag

visualize-admin · Nov 6, 2024 · 64c4d7a · 64c4d7a
1 parent 70f884d
commit 64c4d7a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,7 +11,8 @@ You can also check the
 
 # Unreleased
 
-Nothing yet.
+- Features
+  - Removed a flag for shared dashboard filters
 
 # [4.9.3] - 2024-10-29
 

diff --git a/app/configurator/components/layout-configurator.tsx b/app/configurator/components/layout-configurator.tsx
@@ -52,20 +52,18 @@ import {
   TemporalDimension,
   TemporalEntityDimension,
 } from "@/domain/data";
-import { useFlag } from "@/flags";
 import { useTimeFormatLocale, useTimeFormatUnit } from "@/formatters";
 import { useConfigsCubeComponents } from "@/graphql/hooks";
 import { useLocale } from "@/src";
 import { useDashboardInteractiveFilters } from "@/stores/interactive-filters";
 import { getTimeFilterOptions } from "@/utils/time-filter-options";
 
 export const LayoutConfigurator = () => {
-  const sharedFiltersFlag = useFlag("layouter.dashboard.shared-filters");
   return (
     <>
       <LayoutAnnotator />
       <LayoutLayoutConfigurator />
-      {sharedFiltersFlag ? <LayoutSharedFiltersConfigurator /> : null}
+      <LayoutSharedFiltersConfigurator />
     </>
   );
 };

diff --git a/app/flags/flag.tsx b/app/flags/flag.tsx
@@ -92,7 +92,6 @@ const initFromHost = (host: string) => {
     isVercelPreviewHost(host)
   ) {
     setDefaultFlag("configurator.add-dataset.shared", true);
-    setDefaultFlag("layouter.dashboard.shared-filters", true);
   }
 };
 

diff --git a/app/flags/types.ts b/app/flags/types.ts
@@ -5,8 +5,6 @@ export type FlagName =
   | "debug"
   /** Whether we can add dataset from shared dimensions */
   | "configurator.add-dataset.shared"
-  /** Whether we can use shared filters on dashboard layout */
-  | "layouter.dashboard.shared-filters"
   /** Whether server side cache is disabled */
   | "server-side-cache.disable"
   /** The GraphQL endpoint, is used for testing purposes */
-Original file line number
+Diff line change
@@ Expand Up / @@ -92,7 +92,6 @@ const initFromHost = (host: string) => { @@
         isVercelPreviewHost(host)
       ) {
         setDefaultFlag("configurator.add-dataset.shared", true);
-        setDefaultFlag("layouter.dashboard.shared-filters", true);
       }
     };
@@ Expand Down @@