Merge pull request #395 from visualize-admin/fix/no-se-in-filters

visualize-admin · Feb 21, 2022 · 5e082a7 · 5e082a7
2 parents aa247f1 + a71f47e
commit 5e082a7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/configurator/components/chart-configurator.tsx b/app/configurator/components/chart-configurator.tsx
@@ -19,6 +19,7 @@ import {
 import { getFieldComponentIris } from "../../charts";
 import { chartConfigOptionsUISpec } from "../../charts/chart-config-ui-options";
 import { Loading } from "../../components/hint";
+import { isStandardErrorDimension } from "../../domain/data";
 import {
   DataCubeMetadataWithComponentValuesQuery,
   PossibleFiltersDocument,
@@ -291,7 +292,10 @@ export const ChartConfigurator = ({
       [(x) => keysOrder[x.iri] ?? Infinity]
     );
     const addableDimensions = data?.dataCubeByIri.dimensions.filter(
-      (dim) => !mappedIris.has(dim.iri) && keysOrder[dim.iri] === undefined
+      (dim) =>
+        !mappedIris.has(dim.iri) &&
+        keysOrder[dim.iri] === undefined &&
+        !isStandardErrorDimension(dim)
     );
 
     const handleDragEnd: OnDragEndResponder = (result) => {

diff --git a/app/domain/data.ts b/app/domain/data.ts
@@ -208,6 +208,10 @@ export const isStandardErrorResolvedDimension = (dim: ResolvedDimension) => {
   return dim.data?.related.some((x) => x.type === "StandardError");
 };
 
+export const isStandardErrorDimension = (dim: DimensionMetaDataFragment) => {
+  return dim?.related?.some((r) => r.type === "StandardError");
+};
+
 export const shouldValuesBeLoadedForResolvedDimension = (
   dim: ResolvedDimension
 ) => {