fix: Undefined observations in legend domain

visualize-admin · Jan 25, 2022 · 56f5557 · 56f5557
1 parent 07c9659
commit 56f5557
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/app/charts/map/map-legend.tsx b/app/charts/map/map-legend.tsx
@@ -199,7 +199,7 @@ const CircleLegend = () => {
   const domainObservations = useMemo(
     () => dataDomain.map((d) => data.find((x) => getValue(x) === d)),
     [data, dataDomain, getValue]
-  ) as [Observation, Observation];
+  ) as [Observation | undefined, Observation | undefined];
 
   return (
     <svg width={width} height={HEIGHT}>
@@ -210,11 +210,12 @@ const CircleLegend = () => {
       >
         {dataDomain.map((d, i) => {
           const observation = domainObservations[i];
-          const label = getLabel(observation);
-          const radius = radiusScale(d);
 
-          return (
-            observation && (
+          if (observation) {
+            const label = getLabel(observation);
+            const radius = radiusScale(d);
+
+            return (
               <>
                 {
                   <Circle
@@ -229,8 +230,8 @@ const CircleLegend = () => {
                   />
                 }
               </>
-            )
-          );
+            );
+          }
         })}
 
         {/* Hovered data point indicator */}