fix 🐛: PR reviews

visualize-admin · Dec 3, 2024 · 51114bd · 51114bd
1 parent 535f4e6
commit 51114bd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/charts/shared/chart-state.ts b/app/charts/shared/chart-state.ts
@@ -356,7 +356,7 @@ export type NumericalYVariables = {
 
 export const useNumericalYVariables = (
   // Combo charts have their own logic for y scales.
-  chartType: "area" | "column" | "bar" | "line" | "pie" | "scatterplot",
+  chartType: "area" | "column" | "line" | "pie" | "scatterplot",
   y: GenericField,
   { measuresById }: { measuresById: MeasuresById }
 ): NumericalYVariables => {
@@ -378,7 +378,6 @@ export const useNumericalYVariables = (
       switch (chartType) {
         case "area":
         case "column":
-        case "bar":
         case "pie":
           return Math.min(0, min(data, _getY) ?? 0);
         case "line":

diff --git a/app/config-types.ts b/app/config-types.ts
@@ -1008,6 +1008,7 @@ type ColumnAdjusters = BaseAdjusters<ColumnConfig> & {
     y: { componentId: FieldAdjuster<ColumnConfig, string> };
     segment: FieldAdjuster<
       ColumnConfig,
+      | BarSegmentField
       | LineSegmentField
       | AreaSegmentField
       | ScatterPlotSegmentField
@@ -1042,6 +1043,7 @@ type LineAdjusters = BaseAdjusters<LineConfig> & {
     segment: FieldAdjuster<
       LineConfig,
       | ColumnSegmentField
+      | BarSegmentField
       | AreaSegmentField
       | ScatterPlotSegmentField
       | PieSegmentField
@@ -1057,6 +1059,7 @@ type AreaAdjusters = BaseAdjusters<AreaConfig> & {
     segment: FieldAdjuster<
       AreaConfig,
       | ColumnSegmentField
+      | BarSegmentField
       | LineSegmentField
       | ScatterPlotSegmentField
       | PieSegmentField
@@ -1071,6 +1074,7 @@ type ScatterPlotAdjusters = BaseAdjusters<ScatterPlotConfig> & {
     segment: FieldAdjuster<
       ScatterPlotConfig,
       | ColumnSegmentField
+      | BarSegmentField
       | LineSegmentField
       | AreaSegmentField
       | PieSegmentField
@@ -1086,6 +1090,7 @@ type PieAdjusters = BaseAdjusters<PieConfig> & {
     segment: FieldAdjuster<
       PieConfig,
       | ColumnSegmentField
+      | BarSegmentField
       | LineSegmentField
       | AreaSegmentField
       | ScatterPlotSegmentField
@@ -1100,6 +1105,7 @@ type TableAdjusters = {
   fields: FieldAdjuster<
     TableConfig,
     | ColumnSegmentField
+    | BarSegmentField
     | LineSegmentField
     | AreaSegmentField
     | ScatterPlotSegmentField