fix: Dimension values are correctly sorted in filters

FIx #973
visualize-admin · Feb 24, 2023 · 47825c9 · 47825c9
1 parent ad0a9de
commit 47825c9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/configurator/components/field.tsx b/app/configurator/components/field.tsx
@@ -56,7 +56,6 @@ import {
   useConfiguratorState,
 } from "@/configurator/configurator-state";
 import { FIELD_VALUE_NONE } from "@/configurator/constants";
-import { DimensionValue } from "@/domain/data";
 import { truthy } from "@/domain/types";
 import { useTimeFormatLocale } from "@/formatters";
 import { DimensionMetadataFragment, TimeUnit } from "@/graphql/query-hooks";
@@ -176,7 +175,10 @@ export const DataFilterSelect = ({
 
   const sortedValues = useMemo(() => {
     const sorters = makeDimensionValueSorters(dimension);
-    const sortedValues = orderBy(dimension.values, sorters) as DimensionValue[];
+    const sortedValues = orderBy(
+      dimension.values,
+      sorters.map((s) => (dv) => s(dv.label))
+    );
 
     return sortedValues;
   }, [dimension]);