fix: Do not measure the container height when resetting table view

visualize-admin · Sep 20, 2022 · 348b5d4 · 348b5d4 · vercel · Sep 20, 2022
1 parent e916e20
commit 348b5d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/components/chart-footnotes.tsx b/app/components/chart-footnotes.tsx
@@ -60,7 +60,7 @@ export const ChartFootnotes = ({
   const classes = useStyles();
   const locale = useLocale();
   const [shareUrl, setShareUrl] = useState("");
-  const { state: isTablePreview, setState: setIsTablePreview } =
+  const { state: isTablePreview, setStateRaw: setIsTablePreview } =
     useChartTablePreview();
   // Reset back to chart view when switching chart type.
   useEffect(() => {

diff --git a/app/components/chart-table-preview.tsx b/app/components/chart-table-preview.tsx
@@ -14,13 +14,15 @@ import {
 type Context = {
   state: boolean;
   setState: Dispatch<SetStateAction<boolean>>;
+  setStateRaw: Dispatch<SetStateAction<boolean>>;
   containerRef: RefObject<HTMLDivElement>;
   containerHeight: RefObject<"auto" | number>;
 };
 
 const ChartTablePreviewContext = createContext<Context>({
   state: true,
   setState: () => {},
+  setStateRaw: () => {},
   containerRef: { current: null },
   containerHeight: { current: "auto" },
 });
@@ -66,10 +68,11 @@ export const ChartTablePreviewProvider = ({
     return {
       state,
       setState,
+      setStateRaw,
       containerRef,
       containerHeight,
     };
-  }, [setState, state]);
+  }, [setState, state, containerRef, containerHeight, setStateRaw]);
   return (
     <ChartTablePreviewContext.Provider value={ctx}>
       {children}