refactor: Move dimensions to second useMemo

visualize-admin · Sep 6, 2024 · 264850c · 264850c
1 parent 434702c
commit 264850c
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/app/charts/shared/use-combined-temporal-dimension.ts b/app/charts/shared/use-combined-temporal-dimension.ts
@@ -31,13 +31,10 @@ export const useCombinedTemporalDimension = () => {
       locale,
     },
   });
-  const dimensions = useMemo(
-    () => data?.dataCubesComponents.dimensions ?? [],
-    [data?.dataCubesComponents.dimensions]
-  );
-
   return useMemo(() => {
-    const timeUnitDimensions = dimensions.filter(
+    const timeUnitDimensions = (
+      data?.dataCubesComponents.dimensions ?? []
+    ).filter(
       (dimension) =>
         isTemporalDimensionWithTimeUnit(dimension) &&
         potentialTimeRangeFilterIris.includes(dimension.iri)
@@ -83,5 +80,9 @@ export const useCombinedTemporalDimension = () => {
     };
 
     return combinedDimension;
-  }, [dimensions, formatLocale, potentialTimeRangeFilterIris]);
+  }, [
+    data?.dataCubesComponents.dimensions,
+    formatLocale,
+    potentialTimeRangeFilterIris,
+  ]);
 };