-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darkmode toggle and various other UX/UI improvements #667
Merged
visualapproach
merged 14 commits into
visualapproach:development_v4
from
colinpeddle:darkmode
Jan 26, 2024
Merged
darkmode toggle and various other UX/UI improvements #667
visualapproach
merged 14 commits into
visualapproach:development_v4
from
colinpeddle:darkmode
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ach-patch-1 Update README.md
fix: ha autodiscovery broken
Primarily wanted to add dark mode, but also took the opportunity to clean up some of the UX/UI of the controller's pages. At some point this will need to be converted to react. Due to the nature of the initial build of the HTML dark mode is a bit wonky but the primary goal of not being blinded whilst in a dark hot tub or elsewhere is achieved. Stylisticly some of the CSS and design queues were updated to be cleaner, but work remains. For example, the buttons on the controller for temp/air temp, etc. need be improved.
Thanks, sounds interesting. I'll check it out when I get home in a few days. |
Still a few things to do on the UI/UX side. Have to add some clarity to the design on dark mode toggle just as an indicator of what it is for (sun/moon HTML characters probably). Also have added back the design for heateron and heateroff classes to better indicate the heater is heating, as you had it originally.
…________________________________
From: visualapproach ***@***.***>
Sent: Friday, January 26, 2024 12:42:47 PM
To: visualapproach/WiFi-remote-for-Bestway-Lay-Z-SPA ***@***.***>
Cc: Colin Peddle ***@***.***>; Author ***@***.***>
Subject: Re: [visualapproach/WiFi-remote-for-Bestway-Lay-Z-SPA] darkmode toggle and various other UX/UI improvements (PR #667)
Merged #667<#667> into development_v4.
—
Reply to this email directly, view it on GitHub<#667 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFB7X2C4OFULUDBJBRRMADTYQPIX7AVCNFSM6AAAAABCHMLFK6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGYYTANJZGU3TCOA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I merged the PR. I think it had a fresh look to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily wanted to add dark mode, but also took the opportunity to clean up some of the UX/UI of the controller's pages.
At some point this will need to be converted to React in the near future. Due to the nature of the initial build of the HTML dark mode is a bit wonky but the primary goal of not being blinded whilst in a dark hot tub or elsewhere is achieved.
Stylistically some of the CSS and design queues were updated to be cleaner, but work remains. For example, the buttons on the controller for temp/air temp, etc. need be improved.