Feature: include "take control" state when restoring / restarting #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, can you confirm it works ok? |
|
Yep, I've been running it for a few days now, and as far as I can tell, has worked correctly when needing to power back on following a brief power cut in addition to testing that I'd done Only thing I noticed was in the states file it puts true / false rather than 1 / 0 that the other on/off settings use. But if/as 1 = true = on, it parses it ok |
|
Thanks, I pulled it in and added a conversion from bool to uint8_t to make it look consistent and saving 6 bytes of transmission :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable 4 wire devices to restore state of heater / pump on reboot