Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all the latest changes for the 4-wire #190

Merged
merged 16 commits into from
Jan 21, 2022

Conversation

torei
Copy link
Contributor

@torei torei commented Jan 19, 2022

No description provided.

@visualapproach
Copy link
Owner

did "tttt" not work or did you dislike it? Both is also a valid combo...

@torei
Copy link
Contributor Author

torei commented Jan 19, 2022

uhm.. it wasnt available in the html/js and also not in the BWC? or did i miss something

@visualapproach
Copy link
Owner

uhm.. it wasnt available in the html/js and also not in the BWC? or did i miss something

If I bothered to check before asking... Feat not implemented in 4-wire. Doable, but do people really need it? It's kinda inaccurate anyway

@torei
Copy link
Contributor Author

torei commented Jan 19, 2022

i have bugs on that in my environment. still want to check that but i really dont need it. i count 1 hour with +2°C

@visualapproach
Copy link
Owner

how does the bug show?

@torei
Copy link
Contributor Author

torei commented Jan 19, 2022

kind of.. crazy

image

@visualapproach
Copy link
Owner

Okay, actually I don't consider it a bug per se. It calculates where the temperature curve (if it where a straight line) hits the target temperature line. In case of falling temperature below the target, the curves diverge and will never cross. The crossing occured in the past. Hence negative values. Due to some lag the calculation can look crazy before it gets a couple of consistent readings.

@chunkysteveo
Copy link
Contributor

Ohh is tttt the time to target temp?? I'd like that in the 4 wire code 🙏

@torei
Copy link
Contributor Author

torei commented Jan 19, 2022

Ohh is tttt the time to target temp?? I'd like that in the 4 wire code pray

NOOOO :D

@visualapproach
Copy link
Owner

sorry @torei , I updated again after your merger. Now with your beloved tttt and more updates of states.

@torei
Copy link
Contributor Author

torei commented Jan 19, 2022

lulz. ok. will enable the tttt html stuff tomorrow :-)

@torei
Copy link
Contributor Author

torei commented Jan 20, 2022

@chunkysteveo anything else? :D

@torei torei marked this pull request as ready for review January 21, 2022 07:21
@visualapproach visualapproach merged commit e53cd9c into visualapproach:development Jan 21, 2022
@torei torei deleted the feature/4wireUpdate branch January 22, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants