Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deep-object-assign): remove and prohibit console.log() #446

Merged
merged 1 commit into from
Jul 18, 2020
Merged

fix(deep-object-assign): remove and prohibit console.log() #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ module.exports = {
},
],

// Disable console log.
"no-console": ["error", { allow: ["info", "warn", "error"] }],

// This would be a breaking change for little gain. Though there definitely
// is some merit in this.
"@typescript-eslint/ban-types": "off",
Expand Down
1 change: 0 additions & 1 deletion src/deep-object-assign.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ export function deepObjectAssign<T>(target: T, ...sources: Assignable<T>[]): T;
export function deepObjectAssign(...values: readonly any[]): any {
const merged = deepObjectAssignNonentry(...values);
stripDelete(merged);
console.log(merged);
return merged;
}

Expand Down