fix(timeline.setgroups): nested groups fold correcly when input is array

[strazto]

Squash preferered, HEAD is a revert of a commit that added a demo

Fixes #113

checkout 1a8fd7e to see demonstration, head doesn't include this as the example isn't intended for production, and I want to expedite the review.

[melloware]

looks like you have a conflict?

[strazto]

Yeah, i guess in the last fortnight there's been some changes.
I'd prefer the reviewer address such conflicts, if possible

[melloware]

I don't know about this project but typically that is not how it works. You would rebase this branch and get your PR working. Or close this PR and open another one on the latest version of the code with your fixes again. Just my two cents...

[strazto]

Yeah, you're right
I'll get around to it when I'm at a computer, I just have a few PRs open against master and I dont want to update them if they're going to collect dust

[strazto]

Hm, the conflict looks non-trivial - I don't really understand its purpose, but it's possibly intended to address the same behaviour I am. I'll check the commit log

[strazto]

@Thomaash this conflicted with your commit 36e1482 #729

I'd just like to confirm with you that my merge looks okay to you?

Also @yotamberk or any maintainer, when you get the chance, can you please review this?

[vis-bot]

🎉 This PR is included in version 7.4.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Thomaash]

Hi @matthewstrasiotto,

I don't think you changed my intended behavior in any meaningful way. However, even though I didn't respond on time, please don't use instanceof Array. The problem is that if the array comes from any other context (iframes, web workers etc.) it won't have the same Array in it's prototype chain and won't pass this check even though it is an array and works as one just fine. The function Array.isArray(…) would work much better.

[strazto]

Ah, crap, thanks for the comment @Thomaash - I'm not a JS dev, so I usually just replicate the patterns I see in the codebases I'm working on.
Probably deserves its own PR to address that behaviour

[Thomaash]

Ah, crap, thanks for the comment @Thomaash - I'm not a JS dev, so I usually just replicate the patterns I see in the codebases I'm working on.
Probably deserves its own PR to address that behaviour

Yeah, it was already in the codebase. I solved all of them in #750.