Always pass on errors if no response

[bkeepers]

When an error occurs that prevents an http response from being generated, the exception is currently obscured by an error message like Cannot read property 'status' of undefined. This is because supertest is attempting to make assertions about the response, but the response is undefined.

This updates the existing error logic, which handles network and system errors, to always return the error and skip response assertions if there is no response.

Fixes #352
Fixes #314
Fixes #370

cc @gr2m @wilhelmklopp

[rbarilani]

👍

[luislobo]

Any news when this will be merged?

[pbalan]

+1 Please merge and release

[ddobson]

Would love to see this merged.

[mgcrea]

For god sake @mikelax, please merge this...! Thanks!

[SamD]

How can we get this now, I'm seeing it often

[gr2m]

hey folks, be nice to the open source maintainers, I'm sure they do what they can.

In the meanwhile, you can install it directly from github, just set "supertest": "bkeepers/supertest#unknown-errors" in your package.json until the new version is resolved.

If you want to be helpful, you can publish a package like @yournpmusername/supertest-446 to npm so it will be easier to install it for others, then deprecate it on npm once this PR lands.

Don't make assumptions on how easy it is to merge & release, because we don't know. Show some love and patience <3

[cff3]

Thanks, @gr2m. Using the version from bkeepers works for me. I can now see where the failures in my code happens.

[kibertoad]

@mikelax Is there anything I can do to help this land in the master?

[rimiti]

Thank you everybody for your contributions.
I merge it into next release branch.