Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to make screenshot-app work with Express 4 #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jclosure
Copy link

Hi tj,

The code in your screenshot-app was written back in the Express 3 days. It doesn't work with Express 4 in its current form due to a number of changes. I have fixed these issues and tested them to ensure everything runs now. I made the required minimal adaptations to make it run under the latest version of Express. Only 2 files required modification.

  • First app.js no longer has the app.configure( ... ) syntax to accommodate the removal of the configure method in express.
  • Finally, Express no longer has built-in middleware for errorHandling and logging. I simply required them in and used the modules using the new style. These modules were added to package.json to make everything work cleanly.

Requesting that you accept this pull request to keep your repo current.

Thanks,

Jclosure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant