-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for npm (package.json) #41
Comments
Why would you want to install it via npm if it's a frontend library? |
And? =) Anyway, CJS module definition could be useful. |
Oh, nevermind, I don't know how Browserify works yet. |
+1 |
Totally +1. This should be a de facto feature of all modern js libraries. I'm almost frightened to discover move.js is not in npm. Without this it is hard to browserify. Scandalous! |
Not really. But it would be nice to have it on npm. |
This should be easy. Four of the five dependencies have package.json and are already in NPM: For the fifth dependency, css-ease, I already created a pull request providing package.json and the NPM support. After that a package.json can be created for Move.js and There is one issue though. Fortunately it is easily solved. The index.js uses I truly hope that this inclusion of package.json and publishing to NPM is supported by the Move.js community. It is hard to me to see any downsides. @silvenon, thanks for the tip regarding browserify-shim :) |
Wow, you were much more helpful, nice 👍 |
Pull request incoming. Before that I want mention some additional issues that were on the way. First, thanks to @yields for publishing css-ease to npm with such a short notice. The issue I mentioned in the previous comment turned out harder than first expected. The At first I desperately searched some kind of module aliasing feature in component.json or package.json. Of course issue would be solved if A try/catch solution were hinted by tj and proposed by stephenmathieson to fix the issue. An ugly one but seemed to be the only option. I tried it and it worked out but while analysing the resulting move.js script, I surprisingly stumbled upon something much more elegant: component(1) understood both So no more tries or catches were needed. In the end, the only thing needed for package.json compatibility was to change |
The pull request has now been submitted and waiting for the merge. Could @yields help us out here, once again? :) |
Hey @yields - any change of merging this and publishing to npm? 👍 |
i can't maintain this lib anymore :(, don't have time to invest in it ATM (cc @tj) |
Am I wrong, or there is no way not to install it via npm?
The text was updated successfully, but these errors were encountered: