apply nitpicks

vishvamsinh28 · Dec 14, 2024 · ccc22cb · ccc22cb
1 parent 89f7fbc
commit ccc22cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/scripts/build-post-list.js b/scripts/build-post-list.js
@@ -32,7 +32,7 @@ async function buildPostList(postDirectories, basePath, writeFilePath) {
       const missing = [];
       if (!basePath) missing.push('basePath');
       if (!writeFilePath) missing.push('writeFilePath');
-      throw new Error(`Error while building post list: ${missing.join(' and ')} ${missing.length > 1 ? 'are' : 'is'} required`);
+      throw new Error(`${missing.join(' and ')} ${missing.length > 1 ? 'are' : 'is'} required`);
     }
 
     if (postDirectories.length === 0) {
@@ -57,10 +57,9 @@ async function walkDirectories(directories, resultObj, basePath, sectionTitle, s
 
     for (let file of files) {
       let details;
-      const fileName = posix.join(directory, file);
-      const fileNameWithSection = posix.join(fileName, '_section.mdx')
-      const normalizedSlug = posix.join('/', relative(basePath, fileName))
-      const slug = normalizedSlug.replace(/\\/g, '/')
+      const fileName = normalize(join(directory, file));
+      const fileNameWithSection = normalize(join(fileName, '_section.mdx'))
+      const slug = '/' + normalize(relative(basePath, fileName)).replace(/\\/g, '/')
       const slugElements = slug.split('/')
 
       if (await isDirectory(fileName)) {

diff --git a/tests/build-post-list.test.js b/tests/build-post-list.test.js
@@ -212,15 +212,15 @@ describe('buildPostList', () => {
     await expect(
       buildPostList(postDirectories, undefined, writeFilePath),
     ).rejects.toThrow(
-      "Error while building post list: Error while building post list: basePath is required",
+      "Error while building post list: basePath is required",
     );
   });
 
   it('throws specific error message when writeFilePath parameter is undefined', async () => {
     await expect(
       buildPostList(postDirectories, tempDir, undefined),
     ).rejects.toThrow(
-      "Error while building post list: Error while building post list: writeFilePath is required",
+      "Error while building post list: writeFilePath is required",
     );
   });