apply coderabbit suggestions

vishvamsinh28 · Dec 10, 2024 · 4893712 · 4893712
1 parent 98231ea
commit 4893712
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/tests/build-post-list.test.js b/tests/build-post-list.test.js
@@ -1,6 +1,6 @@
 const fs = require('fs-extra');
 const { resolve, join } = require('path');
-const { setupTestDirectories } = require('./helper/buildPostListSetup')
+const { setupTestDirectories, generateTempDirPath } = require('./helper/buildPostListSetup')
 const { buildPostList, slugifyToC } = require('../scripts/build-post-list');
 
 describe('buildPostList', () => {
@@ -9,10 +9,7 @@ describe('buildPostList', () => {
   let postDirectories;
 
   beforeEach(async () => {
-    tempDir = resolve(
-      __dirname,
-      `test-config-${Date.now()}-${Math.random().toString(36).slice(2)}`,
-    );
+    tempDir = generateTempDirPath(__dirname);
     writeFilePath = resolve(tempDir, 'posts.json');
     postDirectories = [
       [join(tempDir, 'blog'), '/blog'],
@@ -28,12 +25,15 @@ describe('buildPostList', () => {
     await fs.remove(tempDir);
   });
 
-  it('builds a post list and writes the result to a file', async () => {
+  it('writes the result to a file', async () => {
     await buildPostList(postDirectories, tempDir, writeFilePath);
 
     const outputExists = await fs.pathExists(writeFilePath);
     expect(outputExists).toBe(true);
+  });
 
+  it('correctly structures docs entries', async () => {
+    await buildPostList(postDirectories, tempDir, writeFilePath);
     const output = JSON.parse(await fs.readFile(writeFilePath, 'utf-8'));
 
     expect(output.docs).toEqual(
@@ -54,6 +54,11 @@ describe('buildPostList', () => {
         }),
       ]),
     );
+  });
+
+  it('correctly structures blog entries', async () => {
+    await buildPostList(postDirectories, tempDir, writeFilePath);
+    const output = JSON.parse(await fs.readFile(writeFilePath, 'utf-8'));
 
     expect(output.blog).toEqual(
       expect.arrayContaining([

diff --git a/tests/helper/buildPostListSetup.js b/tests/helper/buildPostListSetup.js
@@ -1,6 +1,6 @@
 const { TEST_CONTENT } = require("../fixtures/buildPostListData");
 const fs = require('fs-extra');
-const { join } = require("path")
+const { join, resolve } = require("path")
 
 async function setupTestDirectories(tempDir) {
     const dirs = ['blog', 'docs', 'about'];
@@ -14,4 +14,11 @@ async function setupTestDirectories(tempDir) {
     await fs.ensureDir(join(tempDir, TEST_CONTENT.docs.dir, TEST_CONTENT.docs.subDir));
 }
 
-module.exports = { setupTestDirectories };
+function generateTempDirPath(baseDir) {
+    return resolve(
+        baseDir,
+        `test-config-${Date.now()}-${Math.random().toString(36).slice(2)}`
+    );
+}
+
+module.exports = { setupTestDirectories, generateTempDirPath };