Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 colours - DarkKhaki,DarkMagenta and 2 languages - Corsican,Croatian #142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EsharkyTheGreat
Copy link

@EsharkyTheGreat EsharkyTheGreat commented Oct 5, 2021

Added 2 colours - DarkKhaki,DarkMagenta and 2 languages - Corsican,Croatian

@netlify
Copy link

netlify bot commented Oct 5, 2021

✔️ Deploy Preview for wizardly-hoover-38f71b ready!

🔨 Explore the source changes: 81d6565

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-hoover-38f71b/deploys/615c933a51463c0009ba8caa

😎 Browse the preview: https://deploy-preview-142--wizardly-hoover-38f71b.netlify.app/

Copy link
Collaborator

@MukulKolpe MukulKolpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@sakshamgurbhele
Copy link
Collaborator

hey @EsharkyTheGreat, your PR has conflicts with
src/data/colorOptions.js and src/data/translateOptions.js
Updated your forked repo and make commits accordingly. let me know if any kind of help you want

Copy link
Owner

@vishal-codes vishal-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indentation, change the colors as the colors are already present and also update ur forked version using git pull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants