Add onNativeClick callback #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
commented
Feb 20, 2019
| if (this.props.captureDoubleClick) { | ||
| const {eventManager} = this._context; |
There was a problem hiding this comment.
This hack is no longer necessary with the new click handler in InteractiveMap
xintongxia
approved these changes
Feb 22, 2019
xintongxia
reviewed
Feb 22, 2019
| /* global setTimeout */ | ||
| setTimeout(() => { | ||
| eventManager._toggleRecognizer('doubletap', true); | ||
| }, 0); |
There was a problem hiding this comment.
I am surprised that even with 0 timeout works before this change.
Pessimistress
added a commit
that referenced
this pull request
Feb 22, 2019
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #569 (comment)
onClickis fired with delay even ifdoubleClickZoomisfalseonNativeClickprop per discussion