Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix the value type of circle-radius #728

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

AmyFoxFN
Copy link
Contributor

@AmyFoxFN AmyFoxFN commented Feb 13, 2019

Hi,

Really thanks for the nice component suite. It's quite useful and graceful~

However, when I refer to the example of Adding Custom Data. I got a little problem. And find this little bug in example code:

The value of circle-radius should be a number.

And when setting as a string, it will break as throw an error like this:

Error: layers[0].paint.circle-radius: number expected, string found
    at Object.Jr [as emitValidationErrors] (webpack-internal:///./node_modules/mapbox-gl/dist/mapbox-gl.js:6005)
    at De (webpack-internal:///./node_modules/mapbox-gl/dist/mapbox-gl.js:18388)
    at i._load (webpack-internal:///./node_modules/mapbox-gl/dist/mapbox-gl.js:18441)
    at eval (webpack-internal:///./node_modules/mapbox-gl/dist/mapbox-gl.js:18436)

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants