Add @flow to index.js #1108
Closed
Add @flow to index.js #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I just started using react-map-gl for a project I'm doing, where I'm also using flow. In order to do so, I had to create a stub for react-map-gl declaring all types to be any. However, I just realized that the library is already flow typed, which is awesome, but flow still complains that I'm exporting from an untyped module. Looking into visgl#681, it seems I'm not the only one who noticed this. I'm not sure if this would solve the issue or what is the proper way to expose these types to the consumers but if it is not I would be happy to help if someone points me in the right direction.
|
I don't believe this will work. We may need to do something like https://www.jackfranklin.co.uk/blog/npm-flowjs-javascript/ |
|
Looks like we just need to create an additional index.js.flow file: facebook/flow#1996 (comment) |
|
Awesome! I'll give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I just started using react-map-gl for a project I'm doing, where I'm also using flow. In order to do so, I had to create a stub for react-map-gl declaring all types to be any.
However, I just realized that the library is already flow typed, which is awesome, but flow still complains that I'm exporting from an untyped module.
Looking into #681, it seems I'm not the only one who noticed this. I'm not sure if this would solve the issue or what is the proper way to expose these types to the consumers but if it is not I would be happy to help if someone points me in the right direction.