fix(map): add support for new and missing mapOptions #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefulthink
force-pushed
the
fix/new-map-options
branch
3 times, most recently
from
2d1412f
to
e239660
Compare
- add support for colorScheme - add support for renderingType - add missing options to mapOptionKeys - update docs with new props - update tests for props that can't be changed after map creation
usefulthink
force-pushed
the
fix/new-map-options
branch
from
e239660
to
842eb04
Compare
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #471 and a related issue with the new
colorSchemeoption.The cache-key used by the
reuseMapsfunctionality only contained the mapId and not the other map options that can't be changed after the map has been created (colorSchemeandrenderingType).Fixes #471