-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shadertools: PBR module using UBO #2173
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d53fff3
shadertools: Normalize specularColor
felixpalmer 7efd45f
Do not mutate
felixpalmer 9736cd8
Fix exports
felixpalmer 320f9b6
shadertools: Attenuation vec3
felixpalmer a310432
Consistent early returns
felixpalmer 29dfa7f
Fix hello-gltf example
felixpalmer cb86972
WIP fix pbr shaders
felixpalmer b39fa41
Fix shader errors
felixpalmer 90df175
Get something drawing
felixpalmer b776ec1
Get vertex stage working
felixpalmer 6babe8b
Read baseColor sampler
felixpalmer ba46d6c
Frag shader working
felixpalmer c59f45b
Uncomment shader blocks
felixpalmer 9fbe7c0
Bump
felixpalmer 39527ca
uniform rename & type
felixpalmer 40d609c
Move PBRProjection module
felixpalmer 80f7340
Clear up warning
felixpalmer 605d1d4
Lint
felixpalmer 0cb7847
Enable IBL
felixpalmer 7f5f5a2
Merge branch '9.0-release' into felix/pbr-module-fixes
felixpalmer cfe19ca
Add missing file
felixpalmer 3705dcf
Revert version bumps
felixpalmer 06d7da5
Silence type warnings in example
felixpalmer d1c9e30
Remove unused file
felixpalmer 2b442fc
Tidy
felixpalmer 94ef7e1
Rename shader variables with pbr_ convention
felixpalmer 1fbc755
Remove hack
felixpalmer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having to do this is really annoying. Not quite sure when / why it started to happen. We should restore @donmccurdy 's workspaces setup on master or find another way to fix this.