Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadertools: PBR module using UBO #2173

Merged
merged 27 commits into from
Aug 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/tutorials/hello-gltf/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ const lightSources: LightingProps = {
type: 'ambient'
},
directionalLights: [
// @ts-expect-error Remove once npm package updated with new types
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having to do this is really annoying. Not quite sure when / why it started to happen. We should restore @donmccurdy 's workspaces setup on master or find another way to fix this.

{
color: [222, 244, 255],
direction: [1, -0.5, 0.5],
Expand All @@ -120,6 +121,7 @@ const lightSources: LightingProps = {
],
pointLights: [
{
// @ts-expect-error Remove once npm package updated with new types
attenuation: [1, 0, 0],
felixpalmer marked this conversation as resolved.
Show resolved Hide resolved
color: [255, 222, 222],
position: [3, 10, 0],
Expand Down
Loading