Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregation UBO 2/2 #9133

Merged
merged 31 commits into from
Sep 3, 2024
Merged

Aggregation UBO 2/2 #9133

merged 31 commits into from
Sep 3, 2024

Conversation

felixpalmer
Copy link
Collaborator

@felixpalmer felixpalmer commented Sep 2, 2024

Follow up to #9114, for #8997

Change List

  • Port WebGL aggregator classes to UBO
  • Add binOptionsUniforms for passing options into WebGLAggregator classes
  • Port ContourLayer, GridLayer, HexagonLayer & ScreenGridLayer
  • Fix tests & enable on apple

@felixpalmer felixpalmer changed the title WIP Aggregation UBO 1/2 WIP Aggregation UBO 2/2 Sep 2, 2024
Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixpalmer felixpalmer changed the title WIP Aggregation UBO 2/2 Aggregation UBO 2/2 Sep 3, 2024
@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 91.695% (+0.02%) from 91.679%
when pulling 9c116e2 on felix/aggregation-layers-ubo2
into 9a44132 on master.

@felixpalmer felixpalmer merged commit afe6c32 into master Sep 3, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/aggregation-layers-ubo2 branch September 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants