GPU Aggregation (5/8): GridLayer #9096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
force-pushed
the
x/aggregation-5
branch
3 times, most recently
from
be5ee7e
to
826cb88
Compare
ibgreen
approved these changes
Aug 21, 2024
| @@ -13,6 +13,8 @@ export type AggregationProps = { | |||
| operations: AggregationOperation[]; | |||
| /** Additional options to control bin sorting, e.g. bin size */ | |||
| binOptions: Record<string, number | number[]>; | |||
| /** Callback after a channel is updated */ | |||
| onUpdate?: (channel: number) => void; | |||
There was a problem hiding this comment.
Total nits: Make it more specific onUpdateChannel? Or make it extensible onUpdate(options: {channel?: number})?
modules/aggregation-layers/src/aggregation-layer-v9/cpu-aggregator/aggregate.ts
Show resolved
Hide resolved
modules/aggregation-layers/src/aggregation-layer-v9/cpu-aggregator/aggregate.ts
Outdated
Show resolved
Hide resolved
modules/aggregation-layers/src/grid-layer/grid-cell-layer-vertex.glsl.ts
Outdated
Show resolved
Hide resolved
| getAggregatorType(): string { | ||
| const { | ||
| gpuAggregation, | ||
| // lowerPercentile, |
There was a problem hiding this comment.
Maybe some TODO or explanation?
There was a problem hiding this comment.
See PR description
Pessimistress
force-pushed
the
x/aggregation-5
branch
from
826cb88
to
8d42053
Compare
Pessimistress
force-pushed
the
x/aggregation-5
branch
2 times, most recently
from
acde30e
to
d6b7c48
Compare
Pessimistress
force-pushed
the
x/aggregation-5
branch
from
d6b7c48
to
d477dce
Compare
Pessimistress
force-pushed
the
x/aggregation-5
branch
from
c8cfba4
to
2623861
Compare
Pessimistress
force-pushed
the
x/aggregation-5
branch
from
2623861
to
94e670b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7457
There is a breaking change in the calculation of bins (division is moved from world space to common space)
Change List
onUpdateto AggregatorPropscustomOperationsto CPUAggregatorProps for legacy CPUGridLayergetColorValue,getElevationValuecallbacksTODO
*ScaleType,*UpperPercentile,*LowerPercentileprops are temporarily disabled. This is currently unsupported by the unified Aggregator interface. I think non-linear scales (e.g. step, sqrt, log etc.) would be a nice-to-have for both CPU and GPU aggregation. However, calculating percentiles on GPU is out of scope of v9.1.This PR is already pretty big, so I'll try to bring these functionalities back in a separate PR.