-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShaderModule type update #9044
Merged
Merged
ShaderModule type update #9044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
donmccurdy
approved these changes
Jul 24, 2024
ibgreen
approved these changes
Jul 25, 2024
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Following on from previous discussion, this new type for
ShaderModule
allows cross-checking of theuniformTypes
without requiring an additionalas const satisfies
clause.This PR requires visgl/luma.gl#2137
Changes
Generic parameters
The current type has
PropsT
,UniformsT
&BindingsT
, with the latter two not being used much.The new type constructs these generic types from the
Props
type by filtering the via theUniformsOnly
andBindingsOnly
helpers.Type cross checking
The
uniformTypes
now uses theUniformTypes<UniformsT>
to cross check the types between the passed in props and the type expected by the GPU. In the cases where it is not a simple mapping, a customUniformsT
can be passed (e.g. theproject
module)1
Example