Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFilterExtension UBOs #8998

Merged
merged 19 commits into from
Jul 4, 2024
Merged

DataFilterExtension UBOs #8998

merged 19 commits into from
Jul 4, 2024

Conversation

felixpalmer
Copy link
Collaborator

For #8997 tested with examples/website/data-filter & test/apps/data-filter

Change List

  • Add uniformBlock definition
  • Rename variables in shader
  • Change module names to avoid dash
  • Generate unifromTypes dynamically using unifromTypesFromOptions()
  • Test updates

@coveralls
Copy link

Coverage Status

coverage: 89.231% (+0.02%) from 89.216%
when pulling 6552745 on felix/data-filter-ubo
into 14ade11 on master.

Copy link
Collaborator

@donmccurdy donmccurdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there by any chance a 'plain luma.gl' example or documentation on how to use UBOs and shader modules in v9? I feel like I should have a mental model of it by now but I don't really, and would be happy to try writing such a thing up, if it doesn't exist for reference.

modules/extensions/src/data-filter/shader-module.ts Outdated Show resolved Hide resolved
modules/test-utils/src/utils/layer.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 89.231% (+0.02%) from 89.216%
when pulling e5410a4 on felix/data-filter-ubo
into 31ff4bd on master.

@coveralls
Copy link

Coverage Status

coverage: 89.231% (+0.02%) from 89.216%
when pulling e5410a4 on felix/data-filter-ubo
into 31ff4bd on master.

@coveralls
Copy link

Coverage Status

coverage: 89.231% (+0.02%) from 89.216%
when pulling e5410a4 on felix/data-filter-ubo
into 31ff4bd on master.

@felixpalmer felixpalmer merged commit 2195b8b into master Jul 4, 2024
4 checks passed
@felixpalmer felixpalmer deleted the felix/data-filter-ubo branch July 4, 2024 14:49
@felixpalmer
Copy link
Collaborator Author

Is there by any chance a 'plain luma.gl' example or documentation on how to use UBOs and shader modules in v9?

@donmccurdy not much, I did add a bit to the docs recently and you can get some idea from the tests. If you could improve the docs that would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants