Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick luma global exports in core bundle #8574

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Cherry pick luma global exports in core bundle #8574

merged 1 commit into from
Mar 4, 2024

Conversation

Pessimistress
Copy link
Collaborator

For #7457

Shaves ~110k off core dist.min.js

Change List

  • Cherry pick luma global exports in core bundle
  • Remove unnecessary import from ColumnGeometry

@coveralls
Copy link

Coverage Status

coverage: 70.646% (+0.003%) from 70.643%
when pulling 8b68796 on x/core-bundle
into 1d9b7be on master.

@Pessimistress Pessimistress merged commit d9902fb into master Mar 4, 2024
3 checks passed
@Pessimistress Pessimistress deleted the x/core-bundle branch March 4, 2024 16:14
@zakjan zakjan mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@ibgreen ibgreen Awaiting requested review from ibgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @coveralls @felixpalmer