Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v9 postprocessing #8479

Merged
merged 1 commit into from
Feb 8, 2024
Merged

v9 postprocessing #8479

merged 1 commit into from
Feb 8, 2024

Conversation

felixpalmer
Copy link
Collaborator

For #8409

Change List

  • Add types to PostProcessEffect and make generic so as to infer effect props
  • Remove code path for module without any passes
  • Fix rendering by correctly creating framebuffers with samplers & correctly clearing when needed

@felixpalmer felixpalmer mentioned this pull request Feb 8, 2024
Closed
@felixpalmer felixpalmer merged commit d7bbfe4 into master Feb 8, 2024
2 checks passed
@felixpalmer felixpalmer deleted the felix/v9-postprocessing-rebased branch February 8, 2024 15:10
@Pessimistress Pessimistress mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felixpalmer @donmccurdy