[chore] use vite to bundle examples #7559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Jan 5, 2023
| @@ -17,6 +17,6 @@ | |||
| </head> | |||
| <body> | |||
| <div id="viewDiv"></div> | |||
| <script src='app.js'></script> | |||
| <script type="module" src='app.js'></script> | |||
There was a problem hiding this comment.
Will this approach allow us to change app.js to app.ts in the future and have examples in Typescript?
| @@ -10,7 +10,7 @@ Copy the content of this folder to your project. | |||
| npm install | |||
| # or | |||
| yarn | |||
| # bundle and serve the app with webpack | |||
| # bundle and serve the app with vite | |||
| npm start | |||
There was a problem hiding this comment.
Would it also be a good point to recommend using yarn start instead? npm start is a bit unfortunate as it works, but npm start-local doesn't
| "start-local": "webpack-dev-server --env.local --progress --hot --open", | ||
| "build": "webpack -p" | ||
| "start": "vite --open", | ||
| "start-local": "vite --config ../vite.config.local.mjs" |
There was a problem hiding this comment.
Why don't test apps have a build command?
There was a problem hiding this comment.
Didn't think I ever needed to build one.
examples/vite.config.local.mjs
Outdated
| 'process.env.GoogleMapsAPIKey': JSON.stringify(process.env.GoogleMapsAPIKey), | ||
| 'process.env.MapboxAccessToken': JSON.stringify(process.env.MapboxAccessToken) | ||
| }, | ||
| server: {open: true}, |
There was a problem hiding this comment.
I think we should set port to 8080 to be consistent. For API keys or CORS people may have localhost:8080 whitelisted and a port change causes friction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List