add google analytics + fix ts compilation #925
Conversation
place in keys/ga_tag
`yarn build` has been giving a lot of grief about proper types for the pino logger
|
Building/type checking the server code doesn't seem to give me any errors or warnings on both 8a41e92 and 097eb0c. No clues whats happening there.. Is it preventing the build for you? The client build problem looks like the same thing I ran into in #917 which seemed to get fixed by deleting the lockfile and node_modules and reinstalling but its probably bad news if the same thing is happening again |
migration steps for future ref: - replace yarn install with npm install - (npm ci == yarn install --frozen-lockfile) - replace yarn <script> with npm run <script> - use `--` when passing args to scripts called with npm run - replace yarn.lock references with package-lock.json - remove node_modules and yarn.lock, run npm i - optionally prevent using yarn with package.json "engines" trick resolves #926
|
I'm guessing snyk is failing because its expecting to use yarn but I don't have access to it @alee |
Just saw that - I think we can ignore this Snyk - I'll configure it to use a slightly better shared organizational account and send you an invite to that (i.e., not tied to my account 😅) You're right about the TS errors disappearing on a clean rebuild which is just plain weird. I think it might be something non-deterministic related to our usage of docker volume mounts and node_modules and maybe a half-baked typescript upgrade that I was running locally. That said the errors I was seeing didn't seem wrong per se, mostly things like missing arguments to pino, or being oddly finicky about the type of an interpolated value in the log format string (i.e., %d on a string or something like that). I'll see if I can figure out how to reproduce it... |
|
That is odd. I wonder how the parsing/type checking of format string args is even being done, didn't see anything glancing at pino's type definitions |
|
one thing I'm not sure about is the https://medium.com/with-orus/the-5-commandments-of-clean-error-handling-in-typescript-93a9cbdf1af5 |
|
Yeah maybe unlikely to be an issue but should be easy to add May be worth looking through some of the stricter |
remove possibility of redundant `docker compose -f base.yml -f staging.yml -f "staging.yml" ...` that was causing errors in the latest version of docker compose v2.24.1
I don't think our CI is catching ts errors properly -
yarn buildgenerates a ton of complaints regarding pino if you run it manually