Solo game data export #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase and refactor this to use a |
when a game ended mid-round by a hull breach (- system health) card, the apply card command would keep running and create extra solo_game_round records in the db since we have a 3s timeout before officially ending the game. fixed by checking the system health before instead of just the game status * also adds missing m21 between game round and game * migration included does a small amount of cleanup before forming the relationships, more to follow
usage: `yarn cli dump solo [--start <YYYY-MM-DD>] [--end <YYYY-MM-DD>]` now tracking initialSystemHealth and initialPoints values per solo game round. instead of relying on being able to accurately infer this in the future, a (large) migration computes these values for all existing rounds and future games will simply keep track of them at runtime * migration also does some further cleanup of existing rounds by deleting all extra duplicate records in order for the initial values inference to take place resolves virtualcommons/planning#60
|
no issues running on prod data/staging env |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to triple-check since this involves some complicated data migration
exporting is relatively straightforward but there were 2 problems: