forked from paritytech/polkadot-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pallet Referenda] Confirmation Candle #4
Open
pandres95
wants to merge
6
commits into
virto-network:master
Choose a base branch
from
pandres95:pandres95--confirmation-candle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Pallet Referenda] Confirmation Candle #4
pandres95
wants to merge
6
commits into
virto-network:master
from
pandres95:pandres95--confirmation-candle
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandres95
force-pushed
the
pandres95--confirmation-candle
branch
from
March 26, 2024 21:07
acf74ed
to
3a275ea
Compare
pandres95
force-pushed
the
pandres95--confirmation-candle
branch
from
March 26, 2024 21:15
3a275ea
to
6c059c3
Compare
…insic) period within `Ongoing` state.
pandres95
force-pushed
the
pandres95--confirmation-candle
branch
from
March 26, 2024 21:18
6c059c3
to
37798c4
Compare
olanod
requested changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I think we need some minor adjustments but looks good overall :)
pandres95
force-pushed
the
pandres95--confirmation-candle
branch
6 times, most recently
from
April 2, 2024 15:19
09f92e5
to
ca43dbc
Compare
pandres95
force-pushed
the
pandres95--confirmation-candle
branch
from
April 2, 2024 15:23
ca43dbc
to
8c339c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves the Referenda Confirmation by Candle Auction RFC