Colorize blur

[imaNNeo]

added shadow_color attribute and also added setShadowColor and getShadowColor.
tested as well

[vipulasri]

Hello, @imaNNeoFighT I intentionally didn't implement the colored shadow as I wanted to follow the Material Design guidelines. And as per your code is concerned I don't think there was a need for separate BlurBuilder. Also, the colored shadow is not visible as it should be like (Black) colored shadow, alpha will have different values for the different color shades.

[imaNNeo]

Hi, I Convinced if it's not in material guidelines , And about BlurBuilder i'm not sure , because you just converting the bitmap to blurred bitmap and i think it's better to move to a function (Maybe in same class), i attached a screenshot of a blue shadow , take a look. Good Luck i will contribute again on it, if you need something that you hadn't enough time to do it , tell me i like to contribute .

…

On Sun, Jan 14, 2018 at 9:20 AM, Vipul Asri ***@***.***> wrote: Hello, @imaNNeoFighT <https://github.com/imanneofight> I intentionally didn't implement the colored shadow as I wanted to follow the Material Design guidelines. And as per your code is concerned I don't think there was a need for separate BlurBuilder. Also, the colored shadow is not visible as it should be like (Black) colored shadow, alpha will have different values for different color of shades. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGr0FIgB5gO3a0iTh9QZ2J6EkcX1QDUIks5tKZWvgaJpZM4RdQAO> .

[vipulasri]

@imaNNeoFighT Thanks! I will look into it.

[vipulasri]

@imaNNeoFighT can you raise the PR again with these changes which you proposed earlier ?

[imaNNeo]

Yes let me check

[imaNNeo]

I checked it, but it's a little hard for me (because the source branch is removed, and I don't have access to checkout to this pull request),
You can run this code to have these changes as a new branch in your environment,
then make a new PR for it.
git fetch origin merge-requests/{PR Id}/head:{yourBranchName}

For example for here:
git fetch origin merge-requests/2/head:shadow-color

[vipulasri]

@imaNNeoFighT thanks, actually I wanted you to contribute as you were the original contributor of this idea and code.
No issues, I will work on this.

[imaNNeo]

I know, but I think I need to have access to this repo because I don't have access to the code.

[vipulasri]

@imaNNeoFighT Ohh I see. But as far as I know, You can also check the individual commits done and make the same changes again in the new Repo.

1. Add BlurBuilder to separate blur function
2. add shadowColor property
3. fix shadowColor setter,getter bug and add shadowColor to updatable at…

[imaNNeo]

Okay, I'm working on it.

[imaNNeo]

Here you go, #32