Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #143

Merged
merged 2 commits into from
Nov 21, 2018
Merged

Conversation

louismillsdiffblue
Copy link

Hi,

I've analysed your codebase and produced some unit tests for the following classes - Formats and Utils

I've written the tests for these functions with the help of Diffblue Cover.

Hopefully, these tests should help you detect regressions caused by future code changes.

@calvin1978 calvin1978 merged commit 2a41b56 into vipshop:master Nov 21, 2018
@calvin1978
Copy link
Collaborator

thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants