-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Arduino Code and Webpage improvements #384
Conversation
Thanks for opening this pull request! 🤗 📢 Spread the word about @vinitshahdeo/Hacktoberfest2020 repo across your social media channels to help get others involved! Give a shoutout to Check out few other repos below 🚀 Show some ❤️
Say Hi on Twitter! 👋PS: Please add @vinitshahdeo as a reviewer if you haven't added. |
@Severus-Matthew Can you please create a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 👏
|
||
|
||
FirebaseData firebaseData; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Severus-Matthew Why there are many empty lines? Can we please lint it properly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
@vinitshahdeo is it fine now? |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Description
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist:
Reviewer: Vinit Shahdeo