Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display cookies based on the filter i.e. regex(say *.github.com) - Enhanced the domain filter #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bhargava-raju
Copy link

A filter has been applied to domain field to match all the domain names provided in the field control along with their respective cookies. An additional column can be found in the cookies displayed table header "DOMAIN". Also increased the length of the table cell to 20 & 25 for better readability. These changes have been made without touching the other operations.

See the below screenshot:
image

@bhargava-raju bhargava-raju changed the title Enhanced the domain filter Display cookies based on the filter i.e. regex(say *.github.com) - Enhanced the domain filter Oct 7, 2019
@bhargava-raju
Copy link
Author

#hacktoberfest #goodfirstissue

@bhargava-raju bhargava-raju changed the title Display cookies based on the filter i.e. regex(say *.github.com) - Enhanced the domain filter Display cookies based on the filter i.e. regex(say *.github.com) - Enhanced the domain filter #hacktoberfest Oct 8, 2019
@bhargava-raju bhargava-raju changed the title Display cookies based on the filter i.e. regex(say *.github.com) - Enhanced the domain filter #hacktoberfest Display cookies based on the filter i.e. regex(say *.github.com) - Enhanced the domain filter Oct 8, 2019
@vinitshahdeo vinitshahdeo self-requested a review October 9, 2019 05:31
@vinitshahdeo
Copy link
Owner

@bhargava-raju Thank you for the PR! You may look into a few more good first issues here which are up for grabs!

@vinitshahdeo vinitshahdeo added the up-for-grabs Solve the issue and raise your first PR label Oct 11, 2019
Copy link
Author

@bhargava-raju bhargava-raju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the changes and merge the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest up-for-grabs Solve the issue and raise your first PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants